Makefile: use an explicit path for extraction/extraction.v - #591
Merged
Conversation
An implicit relative path passed to -load-vernac-source is looked up in the load path, so an installed package with an "extraction" subdirectory shadows CompCert's own extraction.v. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01L9BGQT7XUuubV6C619DW4b
xavierleroy
approved these changes
Aug 10, 2026
xavierleroy
left a comment
xavierleroy
left a comment
Contributor
There was a problem hiding this comment.
Well spotted, thanks !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make extractionpassesextraction/extraction.vto-load-vernac-source. That path is implicit, so Rocq resolves it against the load path instead of treating it as a filename, and any installed package with anextractionsubdirectory shadows CompCert's own file. CertiCoq installsuser-contrib/CertiRocq/extraction/extraction.v, so when it is present the build fails withCannot find a physical path bound to logical path Glue.glue. Prefixing./makes the path explicit.