fix: normalize OPENAI_API_BASE by stripping trailing /chat/completions - #5488
Open
Sarthak816 wants to merge 1 commit into
Open
fix: normalize OPENAI_API_BASE by stripping trailing /chat/completions#5488Sarthak816 wants to merge 1 commit into
Sarthak816 wants to merge 1 commit into
Conversation
Fixes Aider-AI#5468 - Can't connect Cloudflare gateway. When users set --openai-api-base, they commonly include the full endpoint path (/chat/completions, /openai/chat/completions, /compat/chat/completions). But litellm's openai library appends /chat/completions to the base URL, creating double-path URLs like .../chat/completions/chat/completions. The fix strips trailing /chat/completions from OPENAI_API_BASE so URLs like: .../compat/chat/completions -> .../compat .../openai/chat/completions -> .../openai .../v1/chat/completions -> .../v1 litellm then correctly appends /chat/completions to produce the right URL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5468 - Can't connect Cloudflare gateway
When users set
--openai-api-base, they commonly include the full endpoint path (/chat/completions,/openai/chat/completions,/compat/chat/completions). But litellm's openai library appends/chat/completionsto the base URL, creating double-path URLs like.../chat/completions/chat/completions.Changes in
aider/main.py:Added URL normalization for
OPENAI_API_BASE— strips trailing/chat/completionsso:.../compat/chat/completions→.../compat→ litellm produces.../compat/chat/completions✓.../openai/chat/completions→.../openai→ litellm produces.../openai/chat/completions✓.../v1/chat/completions→.../v1→ litellm produces.../v1/chat/completions✓This fixes Cloudflare Gateway connections and any other OpenAI-compatible proxy where users include the full endpoint path.