fix: join() raises TypeError when joining bytes collections - #169
Open
koteshyelamati wants to merge 1 commit into
Open
fix: join() raises TypeError when joining bytes collections#169koteshyelamati wants to merge 1 commit into
koteshyelamati wants to merge 1 commit into
Conversation
`join([b"foo", b"bar"])` raises TypeError because the implementation always
uses `''.join(colls)` (a str join) even when joining bytes.
Root cause: the str literal `''` is hardcoded as the separator, which fails
for bytes input since you cannot join bytes with a str separator.
Fix: use `cls().join(colls)` instead — `cls` is already computed from
`dest.__class__`, so this uses `bytes().join()` for bytes and `str().join()`
for strings.
Reproducer:
join([b"foo", b"bar"]) # TypeError before fix, b"foobar" after
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
join([b"foo", b"bar"])raisesTypeErrorinstead of returningb"foobar".Root cause
The implementation hardcodes
''.join(colls)— a str join — even when the input is a bytes collection. Python'sstr.join()cannot accept bytes items.Fix
Use
cls().join(colls)instead.clsis already computed earlier in the function asdest.__class__, so this naturally dispatches tobytes().join()for bytes andstr().join()for strings: