fix(lib): update OG_ASSETS sizes to numeric types for Satori rendering (#29895) - #29909
Open
namdamdoi68-oss wants to merge 2 commits into
Open
fix(lib): update OG_ASSETS sizes to numeric types for Satori rendering (#29895)#29909namdamdoi68-oss wants to merge 2 commits into
namdamdoi68-oss wants to merge 2 commits into
Conversation
Fixes issue calcom#29895 where OG image logo and avatar sizes were passed as strings in OG_ASSETS instead of numbers, preventing Satori from rendering logo and avatar elements in generated OG images. Signed-off-by: namdamdoi68-oss <namdamdoi68@gmail.com>
Contributor
|
Welcome to Cal.diy, @namdamdoi68-oss! Thanks for opening this pull request. A few things to keep in mind:
A maintainer will review your PR soon. Thanks for contributing! |
Contributor
📝 WalkthroughWalkthrough
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Author
|
Hi @kalyan-k @hariom-sharma — the type fix for #29895 is ready for review. All Satori OG asset size tests pass cleanly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue #29895 where OG image logo and avatar sizes were defined as strings in
OG_ASSETSinstead of numbers, preventing Satori (next/og/@vercel/og) from rendering logo and avatar elements in generated OG images.