Skip to content

fix(lib): update OG_ASSETS sizes to numeric types for Satori rendering (#29895) - #29909

Open
namdamdoi68-oss wants to merge 2 commits into
calcom:mainfrom
namdamdoi68-oss:feature/issue-29895-og-images-fix
Open

fix(lib): update OG_ASSETS sizes to numeric types for Satori rendering (#29895)#29909
namdamdoi68-oss wants to merge 2 commits into
calcom:mainfrom
namdamdoi68-oss:feature/issue-29895-og-images-fix

Conversation

@namdamdoi68-oss

@namdamdoi68-oss namdamdoi68-oss commented Aug 5, 2026

Copy link
Copy Markdown

Description

Fixes issue #29895 where OG image logo and avatar sizes were defined as strings in OG_ASSETS instead of numbers, preventing Satori (next/og / @vercel/og) from rendering logo and avatar elements in generated OG images.

Fixes issue calcom#29895 where OG image logo and avatar sizes were passed as strings in OG_ASSETS instead of numbers, preventing Satori from rendering logo and avatar elements in generated OG images.

Signed-off-by: namdamdoi68-oss <namdamdoi68@gmail.com>
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Welcome to Cal.diy, @namdamdoi68-oss! Thanks for opening this pull request.

A few things to keep in mind:

  • This is Cal.diy, not Cal.com. Cal.diy is a community-driven, fully open-source fork of Cal.com licensed under MIT. Your changes here will be part of Cal.diy — they will not be deployed to the Cal.com production app.
  • Please review our Contributing Guidelines if you haven't already.
  • Make sure your PR title follows the Conventional Commits format.

A maintainer will review your PR soon. Thanks for contributing!

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

OG_ASSETS now defines numeric values for logo, avatar, and icon dimensions across meeting, app, and generic OG images. Tests import OG_ASSETS and verify the expected numeric values for each asset type.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly states that OG_ASSETS sizes change to numeric types for Satori rendering.
Description check ✅ Passed The description directly explains the numeric size fix and its effect on Satori OG image rendering.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@namdamdoi68-oss

Copy link
Copy Markdown
Author

Hi @kalyan-k @hariom-sharma — the type fix for #29895 is ready for review. All Satori OG asset size tests pass cleanly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant