feat(env): respect environment variables for editor - #235
Open
astropanic wants to merge 7 commits into
Open
Conversation
astropanic
force-pushed
the
main
branch
2 times, most recently
from
August 9, 2026 07:30
a27ea88 to
d01f7ed
Compare
clearloop
reviewed
Aug 9, 2026
Owner
|
thanks for the contribution! could you please bump the patch version btw that once this PR getting merged, it can be published to crates-io directly! |
Co-authored-by: clearloop <tianyi.gc@gmail.com>
Co-authored-by: clearloop <tianyi.gc@gmail.com>
Co-authored-by: clearloop <tianyi.gc@gmail.com>
Co-authored-by: clearloop <tianyi.gc@gmail.com>
Co-authored-by: clearloop <tianyi.gc@gmail.com>
clearloop
reviewed
Aug 10, 2026
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set up the editor based on the
VISUALandEDITORenvironment variables.Precedence:
VISUALenvEDITORenvvimAdditionally update the code to stop clippy from complaining.