feat(hub-ui): render json-render via the iframe view provider - #187
Closed
antfubot wants to merge 1 commit into
Closed
feat(hub-ui): render json-render via the iframe view provider#187antfubot wants to merge 1 commit into
antfubot wants to merge 1 commit into
Conversation
Replaces hub-ui's inline Vue json-render renderer with the hub's iframe view-provider mechanism: - New ViewProvider.vue renders a provider-backed dock (json-render, and any future provider type) in a chromeless pooled iframe pointed at the registered provider SPA, passing the dock's view as ?view=<stateKey> (inline specs are materialized into an ephemeral shared-state key). One pooled iframe per view. - Shows a built-in empty state when no provider is registered for the type. - state/view-providers.ts reads the hub's devframe:view-providers shared state. - Deletes the inline src/client/json-render/ (registry + 17 components) and ViewJsonRender.vue; drops the now-moot --jr-primary bridge (json-render themes itself in its own SPA) and the unused @json-render/core|vue deps. json-render now composes with the hub UI as host + injected iframe provider, framework-agnostically.
antfu
force-pushed
the
feat/hub-ui-view-provider-iframe
branch
from
August 10, 2026 04:55
6638a55 to
ca8ddbd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR D of the json-render view-provider stack (plan:
plans/json-render-ui-packaging.md). Stacked on #186.Replaces hub-ui's inline Vue json-render renderer with the hub's iframe view-provider mechanism, so json-render composes with the hub UI as host + injected iframe provider — framework-agnostically.
ViewProvider.vue— renders a provider-backed dock (json-render, and any future provider type) in a chromeless pooled iframe pointed at the registered provider SPA, passing the dock's view as?view=<stateKey>. Inline specs are materialized into an ephemeral shared-state key so the iframe always gets a stateKey. One pooled iframe per view.state/view-providers.ts— reads the hub'sdevframe:view-providersshared state (from PR C).src/client/json-render/(registry + 17 components) andViewJsonRender.vue; drops the now-moot--jr-primarybridge (json-render themes itself in its own SPA) and the unused@json-render/core|vuedeps.Verified: workspace typecheck (26 pkgs), eslint, knip,
build:css, build (embedded + standalone),build-storybook; hub-ui public API snapshot unchanged.Created with the help of an agent.