Fix issue where plot fails to render if unsupported MathJax version is present on page - #7951
Open
emilykl wants to merge 3 commits into
Open
Fix issue where plot fails to render if unsupported MathJax version is present on page#7951emilykl wants to merge 3 commits into
emilykl wants to merge 3 commits into
Conversation
emilykl
changed the title
camdecoster
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Issue
Closes #7926
Description
Fixes an issue where the presence of an unsupported MathJax version on the page would cause the entire plot not to render if it contained a tex string (
$...$).This was due to the code path which detected an unsupported MathJax version not calling
_callback()directly the way we did in other failure cases. This PR adds a call to_callback()in that case, and adds regression tests for the issue.